Stop forcing MSBuild server for Aspire CLI builds#17313
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix timeout exception for Aspire project on SDK 10.0.300
Stop forcing MSBuild server for Aspire CLI builds
May 20, 2026
eerhardt
approved these changes
May 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes Aspire CLI’s explicit injection of DOTNET_CLI_USE_MSBUILD_SERVER into dotnet run and AppHost dotnet build process invocations, allowing the .NET SDK/environment to control MSBuild server behavior (avoiding failures seen with .NET SDK 10.0.300 on Linux).
Changes:
- Removed the
DOTNET_CLI_USE_MSBUILD_SERVERconfiguration/injection logic fromDotNetCliRunnerforRunAsyncandBuildAsync. - Updated
DotNetCliRunnerTeststo assert that the CLI no longer injectsDOTNET_CLI_USE_MSBUILD_SERVER(including when the setting is present inIConfiguration).
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Cli/DotNet/DotNetCliRunner.cs | Stops injecting DOTNET_CLI_USE_MSBUILD_SERVER for dotnet run and dotnet build executions. |
| tests/Aspire.Cli.Tests/DotNet/DotNetCliRunnerTests.cs | Updates tests to validate the environment variable is no longer injected. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Comment on lines
136
to
140
| [Fact] | ||
| public async Task BuildAsyncUsesConfigurationValueForDotnetCliUseMsBuildServer() | ||
| public async Task BuildAsyncDoesNotInjectConfiguredDotnetCliUseMsBuildServer() | ||
| { | ||
| using var workspace = TemporaryWorkspace.Create(outputHelper); | ||
| var projectFile = new FileInfo(Path.Combine(workspace.WorkspaceRoot.FullName, "AppHost.csproj")); |
Contributor
Author
There was a problem hiding this comment.
Fixed in e42a708 by removing the outdated inline comment so the test description matches current behavior.
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17313Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17313" |
Contributor
|
/backport to release/13.3 |
Contributor
|
Started backporting to |
Contributor
|
@davidfowl backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Creating an empty commit: Initial plan
Applying: Stop forcing MSBuild server for CLI dotnet commands
Using index info to reconstruct a base tree...
M src/Aspire.Cli/DotNet/DotNetCliRunner.cs
M tests/Aspire.Cli.Tests/DotNet/DotNetCliRunnerTests.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Aspire.Cli/DotNet/DotNetCliRunner.cs
Auto-merging tests/Aspire.Cli.Tests/DotNet/DotNetCliRunnerTests.cs
CONFLICT (content): Merge conflict in tests/Aspire.Cli.Tests/DotNet/DotNetCliRunnerTests.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Stop forcing MSBuild server for CLI dotnet commands
Error: The process '/usr/bin/git' failed with exit code 128 |
16 tasks
Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
davidfowl
force-pushed
the
copilot/fix-timeout-error-sdk-10-0-300
branch
from
e42a708 to
3170d83
Compare
Contributor
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
Contributor
|
❓ CLI E2E Tests unknown — 96 passed, 0 failed, 2 unknown (commit View all recordings
📹 Recordings uploaded automatically from CI run #26203609832 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
aspire runcan fail on Linux with .NET SDK 10.0.300 when the CLI forces MSBuild server usage, surfacing as a named-pipe timeout during the AppHost build.CLI behavior
DOTNET_CLI_USE_MSBUILD_SERVERfordotnet run/dotnet buildinvocations.Tests
DotNetCliRunnercoverage to assert the CLI no longer injectsDOTNET_CLI_USE_MSBUILD_SERVER.Checklist
<remarks />and<code />elements on your triple slash comments?